fix: enable boolean values for the event data
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 71d4abd in 34 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/aw-client.ts:9
- Draft comment:
Good update allowing boolean values in EventData, which aligns with JSONPrimitive usage. Ensure that related parts of the codebase properly handle boolean values in event data. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. src/aw-client.ts:9
- Draft comment:
The change to include boolean in EventData is minimal and correct. Ensure that consumers and server-side logic properly handle booleans in event data. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_wzVr18csX7w7ioGo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
audibleandincognitoaw-watcher-web#171Important
Add
booleanas a valid type forEventDatainaw-client.ts.booleanas a valid type forEventDatainaw-client.ts.This description was created by
for 71d4abd. It will automatically update as commits are pushed.